Some fixes, lombok instead of autowired

master
Terekhin Alexandr 5 years ago
parent 9f94469ff1
commit 7558488fc1
  1. 17
      src/main/java/me/bearns/fias/helpers/UpdaterImpl.java
  2. 13
      src/main/java/me/bearns/fias/service/FiasUpdater.java
  3. 25
      src/test/java/me/bearns/fias/UpdaterTest.java

@ -1,16 +1,14 @@
package me.bearns.fias.helpers; package me.bearns.fias.helpers;
import lombok.AllArgsConstructor;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import me.bearns.fias.domain.FiasVersion; import me.bearns.fias.domain.FiasVersion;
import me.bearns.fias.exceptions.CommonException; import me.bearns.fias.exceptions.CommonException;
import me.bearns.fias.exceptions.DownloadException; import me.bearns.fias.exceptions.DownloadException;
import me.bearns.fias.exceptions.UnzipException; import me.bearns.fias.exceptions.UnzipException;
import me.bearns.fias.repository.AddrobjRepository;
import me.bearns.fias.repository.FiasVersionRepository; import me.bearns.fias.repository.FiasVersionRepository;
import me.bearns.fias.service.Downloader; import me.bearns.fias.service.Downloader;
import me.bearns.fias.service.StreamSaver; import me.bearns.fias.service.StreamSaver;
import me.bearns.fias.xml.AddrObjAdapter;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.data.jpa.repository.JpaRepository; import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
import org.springframework.transaction.annotation.Transactional; import org.springframework.transaction.annotation.Transactional;
@ -28,19 +26,16 @@ import org.apache.commons.compress.archivers.zip.ZipFile;
@Slf4j @Slf4j
@Component @Component
@AllArgsConstructor
public class UpdaterImpl implements UpdateHelper { public class UpdaterImpl implements UpdateHelper {
@Autowired private Downloader fileService;
private static Downloader fileService;
@Autowired private FiasVersionRepository versions;
private static FiasVersionRepository versions;
@Autowired private Catalog catalog;
private static Catalog catalog;
@Autowired private StreamSaver unmarshaller;
private static StreamSaver unmarshaller;
//transaction from here //transaction from here
@Transactional(rollbackFor = Exception.class) @Transactional(rollbackFor = Exception.class)

@ -1,5 +1,6 @@
package me.bearns.fias.service; package me.bearns.fias.service;
import lombok.AllArgsConstructor;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import me.bearns.fias.domain.FiasVersion; import me.bearns.fias.domain.FiasVersion;
import me.bearns.fias.exceptions.CommonException; import me.bearns.fias.exceptions.CommonException;
@ -12,16 +13,14 @@ import java.util.*;
@Slf4j @Slf4j
@Service @Service
@AllArgsConstructor
public class FiasUpdater implements Updater { public class FiasUpdater implements Updater {
@Autowired private FiasVersionRepository versions;
private static FiasVersionRepository versions;
@Autowired private OnlineVersion clientStub;
private static OnlineVersion clientStub;
@Autowired private UpdateHelper helper;
private static UpdateHelper helper;
@Override @Override
public void update() throws CommonException { public void update() throws CommonException {
@ -81,6 +80,4 @@ public class FiasUpdater implements Updater {
} }
} }
} }

@ -0,0 +1,25 @@
package me.bearns.fias;
import me.bearns.fias.exceptions.CommonException;
import me.bearns.fias.service.Updater;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.test.context.ActiveProfiles;
import org.springframework.test.context.junit4.SpringRunner;
@ActiveProfiles("test")
@RunWith(SpringRunner.class)
@SpringBootTest
public class UpdaterTest {
@Autowired
Updater service;
@Test
public void integrationTest() throws CommonException {
service.reload(22L);
}
}
Loading…
Cancel
Save